Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9794 - SuiteCRM - Issue in Report module - Order/Sort related (field type) columns issue #9798

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

trungnguyenit08
Copy link

@trungnguyenit08 trungnguyenit08 commented Oct 21, 2022

Description

Update the logic to generate the sort condition sql script in report.

  • Check if this fields is sorting and is related field -> Custom left join to related table and update the sql script to sort by relatedtabe.related_name
  • If not, run default sort.

It's working for multiple link (Module A -> Module B (relationship with A) -> Related field (module C))

Motivation and Context

In report, when sort by related fields, it will sort by related_uuid instead of related name, it look like incorrect, so need to update to sort it correctly,

How To Test This

Create an Report -> Add the related fields to "Fields" section, also select the sort (ASC or DESC).
The result should be order by alphabet of Related name (instead related uuid)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Oct 21, 2022

CLA assistant check
All committers have signed the CLA.

@jack7anderson7
Copy link
Contributor

Hi @trungnguyenit08,

Can you point this PR towards the hotfix branch instead of the master branch.

Thanks,
Jack

@trungnguyenit08 trungnguyenit08 changed the base branch from master to hotfix November 1, 2022 01:42
@trungnguyenit08
Copy link
Author

Hi @trungnguyenit08,

Can you point this PR towards the hotfix branch instead of the master branch.

Thanks, Jack

It's done. So sorry for late.

@trungnguyenhd
Copy link

hi @jack7anderson7
have any updates?

@serhiisamko091184
Copy link
Contributor

Hello @trungnguyenit08 ,
thanks for your contribution!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 4-8 Score given to PRs once assessed labels Apr 12, 2023
@jack7anderson7 jack7anderson7 added the Area: Reports Issues & PRs related to all things regarding reports label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Reports Issues & PRs related to all things regarding reports PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants