Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9807 - Email import fix #9864

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

Lilin20
Copy link

@Lilin20 Lilin20 commented Dec 21, 2022

Description

This change returns the $col variable as an integer. This is needed for the following problem:

Fatal error: Uncaught TypeError: Unsupported operand types: string % int

Motivation and Context

This change is required for people who are using the email import function. There is an issue related to this problem.
This change solves a problem with the email import function.

The current code interprets the $col variable as a string.

How To Test This

Set up SCRM like me:
SCRM 8.2.1
PHP 8.0.26

First, add your E-Mail to your profile. Then go into the Email menu and select any mail. After that press on "Bulk actions" and select "import".

For me: No window comes up just a message saying "An error occurred" with an HTTP 500 response.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184
Copy link
Contributor

Hello @Lilin20 ,
thank you for the contribution!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 4-8 Score given to PRs once assessed labels Apr 14, 2023
@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Jul 18, 2023
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Jul 21, 2023
@jack7anderson7 jack7anderson7 added the Area:Import Issues & PRs related to all things regarding Importing label Aug 31, 2023
@jack7anderson7 jack7anderson7 merged commit 6c12cae into salesagility:hotfix Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Import Issues & PRs related to all things regarding Importing PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants