Fix #9875 SugarFeed shows 0 seconds ago and negative interval for cer…

[abuzarfaris]

…tain datetime formats

Use proper user datetime format to convert datetime string to timestamp in SugarFeed.php

Description

use date_create_from_format with current user datetime format instead of strtotime because strtotime to time does lots of assumtions e.g if the separator is a slash (/), then the American m/d/y is assumed. If the separator is a dash (-) or a dot (.), then the European d-m-y format is assumed

Motivation and Context

SugarFeeds shows correctly for all users with different datetime format settings

How To Test This

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[SuiteBot]

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/bug-in-my-activity-stream/87625/2

[pgorod]

Thanks!
May I suggest some error handling on the return of date_create_from_format?

It's an alias of DateTime::createFromFormat

Return Values

Returns a new DateTime instance or false on failure.

We should probably check if the function returned successfully...

[abuzarfaris]

Thanks! May I suggest some error handling on the return of date_create_from_format?

It's an alias of DateTime::createFromFormat

Return Values

Returns a new DateTime instance or false on failure.

We should probably check if the function returned successfully...
I have added proper logging incase startdate is not parsed

[pgorod]

Thanks @abuzarfaris !

[serhiisamko091184]

Hello @abuzarfaris
thanks for your contribution,

would you be so kind to squash commits in your branch into one (it means to combine multiple commits into single commit)?
Thanks a lot in advance.

Regards,
Serhii

[abuzarfaris]

Hello @abuzarfaris thanks for your contribution,

would you be so kind to squash commits in your branch into one (it means to combine multiple commits into single commit)? Thanks a lot in advance.

Regards, Serhii

I have tried to squash can you check if it's correct

[clemente-raposo]

Hi @abuzarfaris, thank you once again.

There shouldn't be any Merge commits like the following. Because we use rebasing instead of merging (which gives a way cleaner and easier to manage history timeline)

[abuzarfaris]

Hi @abuzarfaris, thank you once again.

There shouldn't be any Merge commits like the following. Because we use rebasing instead of merging (which gives a way cleaner and easier to manage history timeline)

@clemente-raposo Fixed the merge issue and squashed the commits

[johnM2401]

LGTM, Checked each Time and Date Format, appears to as though Hours/Minutes renders as expected.