Fix #9880 - Error when importing currency fields with a decimal separator

[SinergiaCRM]

resolve #9880

Description

If the decimal separator is set to a comma "," in the user's settings, an error occurs when importing currency fields that include decimals because the decimal separator is removed and the result is the value of the field multiplied by 100.
The error was caused by the filter set for importing currency fields being incorrect, as it passes the same filter as float fields, when a currency field, after the currency symbol is removed, should follow the same treatment as a decimal field. This is what has been implemented in the solution.

Motivation and Context

Prevent errors when importing currency fields with different types of decimal separators.

How To Test

1. Set the decimal separator to a comma “,” in the user's settings.
2. Import a record from the Opportunities module with the Opportunity Amount set to a decimal value, for example 1,12.
3. Verify that after the import, the Opportunity Amount field has been set to 1,12.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
  (It would be nice to specify in the documentation that the inheritance of security groups is applied exclusively at record creation time.)
• I have read the How to Contribute guidelines.

[serhiisamko091184]

Hello, @SinergiaCRM ,
Your change appears to be defining $value twice, on line 96 and then on 98.

Thanks,
Serhii

[juanSTIC]

Hello, @SinergiaCRM , Your change appears to be defining $value twice, on line 96 and then on 98.

Thanks, Serhii

Yes, the assignment of $value on line 98 is modifying the value obtained on line 96, which in turn modifies the value of the argument received in the function, I think that should not be a problem.

[clemente-raposo]

Hi @SinergiaCRM,

Thank you for your PR.

Don't we also want to make sure the decimal separator is a "."? or is that what causes the problem on currencies at the moment?

[SinergiaCRM]

Hi @clemente-raposo,

The code should work the same with any decimal separator. The importSanitize() function returns the field value in the format defined by the user, so we only need to remove the thousands separator symbol set in the configuration.

Changing the values of the thousands separator and decimal separator with different characters, such as ",", ".", "@", "#", etc., and testing the import process could be a useful test. In the tests performed, it has worked correctly.

[clemente-raposo]

Hi @SinergiaCRM, thank you. Makes sense.

[clemente-raposo]

LGTM

[johnM2401]

Hey!

I've given this some testing, and it seems like the fix does indeed resolve issues when importing new records.

However, I seem to hit an error when trying to Import & Update records.

I've set my User's Thousands Operator to "."
And decimal operator to ","

Then, Importing to Update two Opportunities, I received the error:
"A non-numeric value encountered on line 3093 in file [crm]/include/database/DBManager.php"
"A non-numeric value encountered on line 3094 in file [crm]/include/database/DBManager.php"

This doesn't seem to happen when importing NEW records, only when updating existing records.

CSV Used attached, for reference:
Opportunitiesz.csv

What are your thoughts?

[SinergiaCRM]

Hey!

I've given this some testing, and it seems like the fix does indeed resolve issues when importing new records.

However, I seem to hit an error when trying to Import & Update records.

I've set my User's Thousands Operator to "." And decimal operator to ","

Then, Importing to Update two Opportunities, I received the error: "A non-numeric value encountered on line 3093 in file [crm]/include/database/DBManager.php" "A non-numeric value encountered on line 3094 in file [crm]/include/database/DBManager.php"

This doesn't seem to happen when importing NEW records, only when updating existing records.

CSV Used attached, for reference: Opportunitiesz.csv

What are your thoughts?

Hi @johnM2401,

What versión of PHP, SuiteCRM, MySQL/MariaDB are you using?

[SuiteBot]

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/import-currency-field/34603/5

[johnM2401]

Apologies for the delay, @SinergiaCRM

I've retested this after merging into the most recent version locally, (7.14), and cannot seem to replicate the issue I've raised above.

After some testing with various combinations of special-character Decimal/Thousands separators, it appears to be working well.

LGTM!