Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9021 - User Preferences Wrong Label. #9999

Merged
merged 1 commit into from Sep 19, 2023
Merged

Fix #9021 - User Preferences Wrong Label. #9999

merged 1 commit into from Sep 19, 2023

Conversation

serhiisamko091184
Copy link
Contributor

Changes to .tpl file for Users module

Description

Same label is used for different fields in one of DetailView templates:
image

To see the issue:

  1. Go to Users list view;
  2. Choose user -> Detail view -> Tab Advanced
  3. Check that labels are the same for different fields:

image

Fixes the issue:
#9021

Motivation and Context

To use correct labels in the application.

How To Test This

Check that correct label is in use.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

serhiisamko091184 added a commit to serhiisamko091184/SuiteCRM that referenced this pull request Mar 28, 2023
@serhiisamko091184
Fix salesagility#9999 - User Preferences Wrong Label.
9375f2b
@serhiisamko091184 serhiisamko091184 changed the title Fix #xxxx - User Preferences Wrong Label. Fix #9999 - User Preferences Wrong Label. Mar 28, 2023
@serhiisamko091184 serhiisamko091184 changed the title Fix #9999 - User Preferences Wrong Label. Fix #9021 - User Preferences Wrong Label. Mar 31, 2023
@jack7anderson7 jack7anderson7 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member labels Mar 31, 2023
@jack7anderson7 jack7anderson7 added the Area:Users Issues & PRs related to all things regarding to Users label Aug 31, 2023
@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Sep 8, 2023
johnM2401
johnM2401 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Sep 12, 2023
@jack7anderson7 jack7anderson7 merged commit d9ccc81 into salesagility:hotfix-7.13.x Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Area:Users Issues & PRs related to all things regarding to Users Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiisamko091184 @clemente-raposo @johnM2401 @jack7anderson7