Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email required bug #352

Open
TwizzX17 opened this issue Sep 29, 2023 · 0 comments
Open

Email required bug #352

TwizzX17 opened this issue Sep 29, 2023 · 0 comments
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Type: Bug Something isn't working

Comments

@TwizzX17
Copy link
Contributor

Issue

After the commit fd0ffa6 in release 8.4, the forms cannot be validated, if you've a required email input field.

It seems like the validator is not correctly being set, i suspect it to because all validators are being set on form initialization, but the email fields are being added afterwards, when clicking the "+" label.

Expected Behavior

The validator should be triggered and the field should be set as valid when filled out with a valid email.

Actual Behavior

The application does not run the needed validators on input change. If email input has been filled out by any value or a valid email, the validator will never set the field as valid.

When inspecting the formGroup -> controls, i can see the email_addresses as "INVALID" and error is set as a invalid because it is required.

Possible Fix

None

Steps to Reproduce

  1. Go to studio and mark field "email1" as required (this can be done in the Leads module).
  2. Go to create / edit a Lead.
  3. Fill out the required input fields.
  4. The validator will prompt you to fill out all required fields.

Context

We cannot save any forms with a required email input.

Your Environment

  • SuiteCRM Version used: 8.4
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome Version 117.0.5938.92 (Official Build) (64-bit)
  • Environment name and version (e.g. MySQL, PHP 7): php 8.2
  • Operating System and version (e.g Ubuntu 16.04): Ubuntu 20.04
@johnM2401 johnM2401 added Type: Bug Something isn't working Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Area: Emails Issues & PRs related to all things regarding emails & email module labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants