Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

closes salesforce-marketingcloud/FuelSDK-Node-SOAP#122 Added Schedule… #123

Merged
9 commits merged into from
Nov 5, 2019
Merged

closes salesforce-marketingcloud/FuelSDK-Node-SOAP#122 Added Schedule… #123

9 commits merged into from
Nov 5, 2019

Conversation

DougMidgley
Copy link
Contributor

closes #122 Added Scheduled method

@DougMidgley
Copy link
Contributor Author

@manivinesh @sfdrogojan @sfcbetiuc any chance one of you can help with getting this merged?

@ghost
Copy link

ghost commented Nov 1, 2019

@DougMidgley, PR is being reviewed

@manivinesh
Copy link
Contributor

Looks like @sfcbetiuc tried to run the tests with the new changes and noticed 17 tests are failing which were not failing in the master branch.

Issue:
Before the PR, the tests were asserting based on the length of object and it was expecting it to be 1 always, now that the new changes make the filters to actually work, the length is now coming as more than 1 and it cause those tests to fail.

To fix this issue:

  1. Pull in the latest code from the master branch and
  2. Fix the length issue in the failing tests.

@sfcbetiuc @DougMidgley

@DougMidgley
Copy link
Contributor Author

Hi @manivinesh @sfcbetiuc thanks for picking this up.
I ran tests locally based on this version and no test failures were caught. I also see the last build https://travis-ci.org/salesforce-marketingcloud/FuelSDK-Node-SOAP/builds/586619208?utm_source=github_status&utm_medium=notification did not show any errors so would be good to understand what can be done here...

@manivinesh
Copy link
Contributor

@DougMidgley Apologies, i meant to add that comment on the FuelSDK-Node module.

@DougMidgley
Copy link
Contributor Author

Hi @manivinesh :) cool, so this can be merged?

@manivinesh
Copy link
Contributor

@DougMidgley Yes, @sfcbetiuc will merge and release the package soon.

@ghost
Copy link

ghost commented Nov 4, 2019

@DougMidgley, can you please increase the version to 2.2.4 in package.json?

@DougMidgley
Bumped version to 2.2.4
36a82fe 
Changed version as per PR reviewer request
@ghost ghost merged commit df1e4e9 into salesforce-marketingcloud:master Nov 5, 2019
colins44 added a commit to email360/FuelSDK-Node-SOAP that referenced this pull request Sep 17, 2020
@colins44
implementing extract function
762b59b 
Tabs not spaces

tabs not spaces

Revert "closes salesforce-marketingcloud#122 Added Schedule… (salesforce-marketingcloud#123)"

This reverts commit df1e4e9.

Revert "tabs not spaces"

This reverts commit a5680d5982cabf3cf8a4cdceb1e9d214bc726427.
ozcanovunc pushed a commit to ozcanovunc/FuelSDK-Node-SOAP that referenced this pull request May 25, 2022
@DougMidgley @ozcanovunc
closes salesforce-marketingcloud#122 Added Schedule… (salesforce-mark…
aa6931b 
…etingcloud#123)

* closes salesforce-marketingcloud#122 Added Schedule Support

* Added Test for Schedule action

* Updated Test case

* Missing semicolon

* Corrected Tests and validated

* Increment Version

* Bumped version to 2.2.4

Changed version as per PR reviewer request

    pick 24dcd6f Removes a line that creates an unnecessary <Objects> tag.
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any workaround for Schedule method?
2 participants
@DougMidgley @manivinesh