This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
first pass at implementing execute method, closes #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,7 @@ | |||
| "chai": "~1.9.1", | |||
| "grunt": "~0.4.5", | |||
| "grunt-bump": "~0.0.14", | |||
| "grunt-cli": "^0.1.13", | |||
There was a problem hiding this comment.
please change this to "~0.1.13"
|
Please add test cases |
| }, | ||
| Requests: { | ||
| Name: type, | ||
| Parameters: props |
There was a problem hiding this comment.
I know this sounds kind of nitpicky, but why not params instead of props? It just seems to make better since.
There was a problem hiding this comment.
I believe @nlf used props because that's in keeping with the style of the rest of the module.
|
added a test. i had a sporadic issue with the last test in |
vernak2539
added a commit
that referenced
this pull request
May 5, 2015
first pass at implementing execute method, closes #48
|
published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
grunt-clito dev dependencies so I wouldn't have to globally install it.