This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
Remove hardcoded version dependencies in setup.py #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is holding back this pr from being merged to master? Its about a year since it was created and the requests library issue is really biting because its pinned to an ancient version. |
|
Thanks for the feedback, it has been taken into consideration, And changes have been made to allow higher versions. In order to avoid issues, the downgrade has been restricted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a user of this SDK and I want to upgrade my version of pyjwt to the latest, 1.0.1, which addresses some nasty security vulnerabilities.
However, I can't, due to the hardcoded versions in setup.py. Removing these versions from setup.py lets downstream consumers of your library use whichever requirements they want, and is good practice. More discussion here if you're curious: https://caremad.io/2013/07/setup-vs-requirement/