Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diversify test suite fixtures? #161

Open
morewry opened this issue Jul 4, 2018 · 1 comment
Open

Diversify test suite fixtures? #161

morewry opened this issue Jul 4, 2018 · 1 comment

Comments

@morewry
Copy link

morewry commented Jul 4, 2018

I noticed that the fixtures for testing the formats all seem to use roughly the same input format, with the properties named using the constant-convention-esque UPPER_SNAKE_CASE.

This means the tests really only cover your cases if you use the same naming convention for your tokens. Since theo's users probably have more diverse input, I wonder if you'd be open to more diverse fixtures that will also provide more complete coverage of what the formats are actually doing (some of the functions applied to e.g. property names will change the output of things like spaces and hyphens, which aren't being reflected in/covered by the test suite currently).

@aputinski
Copy link
Contributor

Yeah, I think expanding the test cases would be a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants