Fix edge case bug in layered models. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of layered models fails if config.model is None, but model is non-None when initializing a layered model. This commit fixes the issue by ensuring that __new__() does not implicitly update the config object when setting model's class.
aadyotb
changed the title
huan-dec
approved these changes
Sep 13, 2022
aadyotb
force-pushed
the
layers_fix
branch
2 times, most recently
from
5e32093
to
1ca2e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of layered models fails if
config.modelisNonebutmodelis notNonewhen initializing a layered model. This commit fixes the issue by ensuring that__new__()does not implicitly update the config object when setting model's class. We also add test coverage for this use case.