adding feature importance for new model types

[leahmcguire]

No description provided.

[codecov]

Codecov Report

Merging #128 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   86.19%   86.15%   -0.04%     
==========================================
  Files         298      298              
  Lines        9668     9672       +4     
  Branches      329      540     +211     
==========================================
  Hits         8333     8333              
- Misses       1335     1339       +4

Impacted Files	Coverage Δ
...c/main/scala/com/salesforce/op/ModelInsights.scala	92.56% <0%> (-1.56%)	⬇️
.../salesforce/op/features/FeatureBuilderMacros.scala	0% <0%> (-100%)	⬇️
...om/salesforce/op/utils/spark/OpSparkListener.scala	98.7% <0%> (+1.29%)	⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala	89.79% <0%> (+4.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078ea62...4e882cb. Read the comment docs.

[tovbinm]

lgtm. can we unit test this simply somehow?

[leahmcguire]

it would not be simple - they would be pretty heavy duty (see long running) tests

[tovbinm]

I mean we can unit test just the getModelContributions and other model isights functions without actually training the models but just instantiating them, e.g:
getModelContributions(Some(new GBTClassificationModel(...))