Use proper test ranges in feature converter test #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajayborra please have a look. |
tovbinm
changed the title
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
+ Coverage 86.25% 86.4% +0.15%
=========================================
Files 299 299
Lines 9749 9748 -1
Branches 538 537 -1
=========================================
+ Hits 8409 8423 +14
+ Misses 1340 1325 -15
Continue to review full report at Codecov.
|
|
Lgtm @tovbinm , 👍the tuple feeding approch with |
leahmcguire
reviewed
Oct 1, 2018
| (arrType(DoubleType), weakTypeTag[types.Geolocation], arrType(DoubleType)), | ||
| (arrType(StringType), weakTypeTag[types.TextList], arrType(StringType)), | ||
| (mapType(StringType), weakTypeTag[types.TextMap], mapType(StringType)), | ||
| (mapType(DoubleType), weakTypeTag[types.RealMap], mapType(DoubleType)), |
There was a problem hiding this comment.
do you need map float, map int, map short, etc as well?
There was a problem hiding this comment.
I thought about it, but I dont think it's that important. Maybe in another PR.
leahmcguire
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#115
Describe the proposed solution
This is a continuation of #135 PR by @ajayborra