CLI command name fix + bump shadow plugin version + cleanup #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 85.75% 85.73% -0.03%
==========================================
Files 303 303
Lines 9912 9912
Branches 543 543
==========================================
- Hits 8500 8498 -2
- Misses 1412 1414 +2
Continue to review full report at Codecov.
|
leahmcguire
approved these changes
Oct 26, 2018
| @@ -49,8 +49,8 @@ configure(allProjs) { | |||
| sourceCompatibility = 1.8 | |||
| targetCompatibility = 1.8 | |||
|
|
|||
| // Max: Set this to the main class for cli. | |||
| // Could not figure out how to configure it just for the cli subproject | |||
| // Set this to the main class for cli. | |||
There was a problem hiding this comment.
There is currently no other way. I also checked ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
CLI shows invalid command name.
Describe the proposed solution
Updated the name + shadow plugin version bump
Describe alternatives you've considered
NA