Time based aggregators #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
reviewed
Oct 27, 2018
features/src/main/scala/com/salesforce/op/aggregators/TimeBasedAggregator.scala
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Oct 27, 2018
|
|
||
| private[op] abstract class TimeBasedAggregator[T <: FeatureType] | ||
| ( | ||
| val compareFun: (Long, Long) => Boolean, |
There was a problem hiding this comment.
Is there any particular reason in making this function a value argument?
tovbinm
reviewed
Oct 27, 2018
features/src/main/scala/com/salesforce/op/aggregators/TimeBasedAggregator.scala
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Oct 27, 2018
features/src/main/scala/com/salesforce/op/aggregators/TimeBasedAggregator.scala
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Oct 27, 2018
| val ftFactory = FeatureTypeFactory[T]() | ||
|
|
||
| val monoid: Monoid[(Long, T#Value)] = new Monoid[(Long, T#Value)] { | ||
| val zero = timeZero -> emptyValue |
There was a problem hiding this comment.
I think you dont need to pass zeroValue, instead simply:
val zero = timeZero -> FeatureTypeDefaults.default[T].valueThere was a problem hiding this comment.
I have to remove support for RealNN since it doesn't have a default - but that may be better anyway
|
@leahmcguire scalastyle is not happy. |
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 85.81% 86.22% +0.41%
==========================================
Files 303 304 +1
Lines 9914 9920 +6
Branches 338 551 +213
==========================================
+ Hits 8508 8554 +46
+ Misses 1406 1366 -40
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made aggregators for first and last event value for all feature types.