Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OS specific path separator #193

Merged
merged 1 commit into from Dec 11, 2018
Merged

Use OS specific path separator #193

merged 1 commit into from Dec 11, 2018

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Dec 11, 2018

Related issues
#192

Describe the proposed solution
Use OS specific path separator

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #193 into master will increase coverage by 6.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   80.33%   86.35%   +6.01%     
==========================================
  Files         309      309              
  Lines       10007    10009       +2     
  Branches      349      557     +208     
==========================================
+ Hits         8039     8643     +604     
+ Misses       1968     1366     -602
Impacted Files Coverage Δ
...la/com/salesforce/op/utils/io/avro/AvroInOut.scala 100% <100%> (ø) ⬆️
.../salesforce/op/features/FeatureBuilderMacros.scala 0% <0%> (-100%) ⬇️
...sforce/op/stages/impl/feature/Transmogrifier.scala 96.74% <0%> (+0.29%) ⬆️
.../op/features/types/FeatureTypeSparkConverter.scala 98.19% <0%> (+0.9%) ⬆️
...n/scala/com/salesforce/op/dsl/RichMapFeature.scala 81.53% <0%> (+1.53%) ⬆️
...in/scala/com/salesforce/op/cli/gen/AvroField.scala 76.92% <0%> (+2.56%) ⬆️
...ges/impl/feature/DateToUnitCircleTransformer.scala 100% <0%> (+3.44%) ⬆️
...s/impl/feature/OPCollectionHashingVectorizer.scala 96.37% <0%> (+3.62%) ⬆️
...com/salesforce/op/utils/stages/FitStagesUtil.scala 94.73% <0%> (+3.94%) ⬆️
...scala/com/salesforce/op/testkit/RandomStream.scala 100% <0%> (+4.76%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f39b8...ffe9326. Read the comment docs.

@tovbinm tovbinm merged commit 04cd7ff into master Dec 11, 2018
@tovbinm tovbinm deleted the mt/paths branch December 11, 2018 18:42
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant