Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate helloworld project with Travis CI #212

Merged
merged 9 commits into from
Feb 7, 2019

Conversation

rajdeepd
Copy link
Contributor

@rajdeepd rajdeepd commented Feb 3, 2019

Related issues
#114

Describe the proposed solution
Added helloworld samples to the travis build

Describe alternatives you've considered
none

Additional context
none

@codecov
Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #212 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   80.63%   80.64%   +<.01%     
==========================================
  Files         323      323              
  Lines       10350    10350              
  Branches      536      536              
==========================================
+ Hits         8346     8347       +1     
+ Misses       2004     2003       -1
Impacted Files Coverage Δ
.../scala/com/salesforce/op/features/types/Maps.scala 92.77% <100%> (ø) ⬆️
.../op/features/types/FeatureTypeSparkConverter.scala 97.29% <0%> (-0.91%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748cf95...0eae32a. Read the comment docs.

@@ -53,6 +55,8 @@ configurations {
dependencies {
// Scala
zinc 'com.typesafe.zinc:zinc:0.3.15'
scoverage "org.scoverage:scalac-scoverage-plugin_$scalaVersion:$scoveragePluginVersion"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need

testCompile "org.scoverage:scalac-scoverage-plugin_$scalaVersion:$scoveragePluginVersion"
testCompile "org.scoverage:scalac-scoverage-runtime_$scalaVersion:$scoveragePluginVersion"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

.travis.yml Outdated Show resolved Hide resolved
@@ -68,3 +72,10 @@ jobs:
echo -e "Test files running on this container : `eval $COUNT_TEST_FILE_CMD`\n$TEST_FILES\n"
./gradlew reportScoverage
name: 'Build Part 4'
- script: |
Copy link
Collaborator

@tovbinm tovbinm Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply do:

- script: |
      cd helloworld && ./gradlew reportScoverage
name: 'Build - Helloworld'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tovbinm fixed

@tovbinm tovbinm merged commit 533c65d into salesforce:master Feb 7, 2019
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants