Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cl/rff metrics #214

Closed
wants to merge 2 commits into from
Closed

Conversation

clin-projects
Copy link
Contributor

Problem
I would like to pass information that is obtained by RawFeatureFilter (RFF) into ModelInsights. Some information is already passed through (via FeatureDistribution) but some critical information is not, e.g., reason why a feature was excluded by RFF.

Describe the proposed solution
Creating RawFeatureInfo case class that contains and passes information through workflow, gets passed to ModelInsights, and can convert information from the RawFeatureFilter stage to JSON.

Current pull request

  • Created RawFeatureInfo case class
  • Moved Feature distribution information into RawFeatureInfo case class
  • Updated test and code dependencies to reflect above changes

Chaney Lin added 2 commits February 5, 2019 15:14
…ribution]; this case class will be used to store other info from RawFeatureFilter (e.g., metrics and inclusion reasons)
@salesforce-cla
Copy link

salesforce-cla bot commented Feb 5, 2019

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Chaney Lin <c***@c***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant