Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indices in LOCO for record-level insights and add more robust tests #216

Merged
merged 7 commits into from
Feb 7, 2019

Conversation

Jauntbox
Copy link
Contributor

@Jauntbox Jauntbox commented Feb 6, 2019

Related issues
N/A

Describe the proposed solution
Simple fix to the indexing of insights that didn't show up because the tests were too simple. Adds a significantly more complex test that includes a more realistic feature engineering DAG, and tests a variety of properties that should hold for record-level insights for randomly generated datasets with a strong relation between the features and the label.

Describe alternatives you've considered
N/A

Additional context
N/A

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #216 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   86.34%   86.36%   +0.01%     
==========================================
  Files         310      310              
  Lines       10137    10137              
  Branches      548      542       -6     
==========================================
+ Hits         8753     8755       +2     
+ Misses       1384     1382       -2
Impacted Files Coverage Δ
...e/op/stages/impl/insights/RecordInsightsLOCO.scala 94.11% <100%> (ø) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2fa5b...9dd893f. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, the test is bizarre. Perhaps use withClue around asserts to provide more details in case of failures?

@Jauntbox Jauntbox merged commit a63559b into master Feb 7, 2019
@Jauntbox Jauntbox deleted the km/loco-fix branch February 7, 2019 19:35
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants