-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indices in LOCO for record-level insights and add more robust tests #216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 86.34% 86.36% +0.01%
==========================================
Files 310 310
Lines 10137 10137
Branches 548 542 -6
==========================================
+ Hits 8753 8755 +2
+ Misses 1384 1382 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, the test is bizarre. Perhaps use withClue
around asserts to provide more details in case of failures?
Related issues
N/A
Describe the proposed solution
Simple fix to the indexing of insights that didn't show up because the tests were too simple. Adds a significantly more complex test that includes a more realistic feature engineering DAG, and tests a variety of properties that should hold for record-level insights for randomly generated datasets with a strong relation between the features and the label.
Describe alternatives you've considered
N/A
Additional context
N/A