Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests a little less flaky #221

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Make tests a little less flaky #221

merged 1 commit into from
Feb 8, 2019

Conversation

Jauntbox
Copy link
Contributor

@Jauntbox Jauntbox commented Feb 8, 2019

Related issues
N/A

Describe the proposed solution
Relaxing tolerances, and reducing random data size in a few cases so that some tests are faster and less prone to random failure.

Describe alternatives you've considered
N/A

Additional context
N/a

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #221 into master will increase coverage by 9.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   77.21%   86.36%   +9.15%     
==========================================
  Files         310      310              
  Lines       10137    10137              
  Branches      347      347              
==========================================
+ Hits         7827     8755     +928     
+ Misses       2310     1382     -928
Impacted Files Coverage Δ
...ala/com/salesforce/op/features/types/package.scala 52.17% <0%> (+0.72%) ⬆️
...rce/op/stages/impl/feature/PhoneNumberParser.scala 100% <0%> (+1.29%) ⬆️
...rce/op/stages/impl/preparators/SanityChecker.scala 91.84% <0%> (+1.9%) ⬆️
...a/com/salesforce/op/readers/JoinedDataReader.scala 94.23% <0%> (+1.92%) ⬆️
...esforce/op/stages/impl/feature/TextTokenizer.scala 100% <0%> (+2.04%) ⬆️
.../salesforce/op/stages/impl/tuning/DataCutter.scala 95.65% <0%> (+2.17%) ⬆️
...op/stages/impl/regression/OpXGBoostRegressor.scala 18.18% <0%> (+2.27%) ⬆️
...p/evaluators/OpBinaryClassificationEvaluator.scala 82.5% <0%> (+2.5%) ⬆️
...ala/com/salesforce/op/dsl/RichNumericFeature.scala 100% <0%> (+2.56%) ⬆️
.../main/scala/com/salesforce/op/OpWorkflowCore.scala 93.54% <0%> (+3.22%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350a3ac...8f96acf. Read the comment docs.

@tovbinm tovbinm merged commit c41d806 into master Feb 8, 2019
@tovbinm tovbinm deleted the km/deflake branch February 8, 2019 02:20
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
@salesforce-cla
Copy link

Thanks for the contribution! It looks like @Jauntbox is an internal user so signing the CLA is not required. However, we need to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants