fix local scoring with multipicklist features #243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 86.39% 86.43% +0.03%
==========================================
Files 312 312
Lines 10187 10187
Branches 336 564 +228
==========================================
+ Hits 8801 8805 +4
+ Misses 1386 1382 -4
Continue to review full report at Codecov.
|
| @@ -117,4 +120,47 @@ class OpWorkflowRunnerLocalTest extends FlatSpec with PassengerSparkFixtureTest | |||
| } score shouldBe expected | |||
| } | |||
|
|
|||
| it should "handle multi picklist features without throwing an exception" in { | |||
There was a problem hiding this comment.
the tests seems an overkill for such a simple check ;) let's think if we can make is simpler and not so labor intensive.
There was a problem hiding this comment.
Let's simply test it in FeatureTypeSparkConverterTest
| @@ -196,7 +196,7 @@ case object FeatureTypeSparkConverter { | |||
|
|
|||
| // Sets | |||
| case wt if wt <:< weakTypeOf[t.MultiPickList] => (value: Any) => | |||
| if (value == null) FeatureTypeDefaults.MultiPickList.value else value.asInstanceOf[MWrappedArray[String]].toSet | |||
| if (value == null) FeatureTypeDefaults.MultiPickList.value else value.asInstanceOf[Seq[String]].toSet | |||
There was a problem hiding this comment.
you would also have to make the same fix for MultiPickListMap
…local-multipicklist
|
Thanks for the contribution! It looks like @kinfaikan is an internal user so signing the CLA is not required. However, we need to confirm this. |
Related issues
NA
Describe the proposed solution
Local scoring fails when there are multipicklist features because
Seqcan't be casted toMWrappedArray. Solution is to cast multipicklist value toSeq.Describe alternatives you've considered
NA
Additional context
NA