Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typing error #259

Merged
merged 2 commits into from Apr 2, 2019

Conversation

@prakhar2b
Copy link
Contributor

commented Apr 2, 2019

Related issues
A typo in the developer guide : This produces and an OpWorkflowModel which can then be saved to disk and applied to another dataset.

@prakhar2b prakhar2b requested review from leahmcguire and tovbinm as code owners Apr 2, 2019
@salesforce-cla salesforce-cla bot added the cla:missing label Apr 2, 2019
@salesforce-cla

This comment has been minimized.

Copy link

commented Apr 2, 2019

Thanks for the contribution! Before we can merge this, we need @prakhar2b to sign the Salesforce.com Contributor License Agreement.

@salesforce-cla salesforce-cla bot added cla:signed and removed cla:missing labels Apr 2, 2019
@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #259 into master will decrease coverage by 10.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #259       +/-   ##
===========================================
- Coverage    86.6%   75.67%   -10.94%     
===========================================
  Files         315      315               
  Lines       10341     6002     -4339     
  Branches      325      291       -34     
===========================================
- Hits         8956     4542     -4414     
- Misses       1385     1460       +75
Impacted Files Coverage Δ
...sforce/op/stages/base/binary/BinaryEstimator.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/aggregators/Geolocation.scala 0% <0%> (-100%) ⬇️
...ala/com/salesforce/op/testkit/InfiniteStream.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/utils/io/avro/AvroInOut.scala 0% <0%> (-100%) ⬇️
...rce/op/stages/impl/feature/JaccardSimilarity.scala 0% <0%> (-100%) ⬇️
.../salesforce/op/aggregators/FeatureAggregator.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/features/types/OPList.scala 0% <0%> (-100%) ⬇️
...n/scala/com/salesforce/op/readers/CSVReaders.scala 0% <0%> (-100%) ⬇️
...stages/base/sequence/BinarySequenceEstimator.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/readers/CSVDefaults.scala 0% <0%> (-100%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd8aa2...b9fa09c. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #259 into master will decrease coverage by 3.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage    86.6%   82.66%   -3.95%     
==========================================
  Files         315      315              
  Lines       10341    10341              
  Branches      325      542     +217     
==========================================
- Hits         8956     8548     -408     
- Misses       1385     1793     +408
Impacted Files Coverage Δ
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/cli/gen/ProblemKind.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/cli/gen/FileInProject.scala 0% <0%> (-100%) ⬇️
...in/scala/com/salesforce/op/cli/CommandParser.scala 0% <0%> (-98.12%) ⬇️
...cala/com/salesforce/op/cli/gen/ProblemSchema.scala 0% <0%> (-96.56%) ⬇️
...src/main/scala/com/salesforce/op/cli/gen/Ops.scala 0% <0%> (-94%) ⬇️
...ain/scala/com/salesforce/op/cli/SchemaSource.scala 0% <0%> (-87.94%) ⬇️
...a/com/salesforce/op/cli/gen/ProjectGenerator.scala 0% <0%> (-87.5%) ⬇️
...in/scala/com/salesforce/op/cli/CliParameters.scala 0% <0%> (-80.96%) ⬇️
...src/main/scala/com/salesforce/op/cli/CliExec.scala 0% <0%> (-80%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd8aa2...b9fa09c. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #259 into master will decrease coverage by 10.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #259       +/-   ##
===========================================
- Coverage    86.6%   75.67%   -10.94%     
===========================================
  Files         315      315               
  Lines       10341     6002     -4339     
  Branches      325      291       -34     
===========================================
- Hits         8956     4542     -4414     
- Misses       1385     1460       +75
Impacted Files Coverage Δ
...sforce/op/stages/base/binary/BinaryEstimator.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/aggregators/Geolocation.scala 0% <0%> (-100%) ⬇️
...ala/com/salesforce/op/testkit/InfiniteStream.scala 0% <0%> (-100%) ⬇️
...la/com/salesforce/op/utils/io/avro/AvroInOut.scala 0% <0%> (-100%) ⬇️
...rce/op/stages/impl/feature/JaccardSimilarity.scala 0% <0%> (-100%) ⬇️
.../salesforce/op/aggregators/FeatureAggregator.scala 0% <0%> (-100%) ⬇️
...cala/com/salesforce/op/features/types/OPList.scala 0% <0%> (-100%) ⬇️
...n/scala/com/salesforce/op/readers/CSVReaders.scala 0% <0%> (-100%) ⬇️
...stages/base/sequence/BinarySequenceEstimator.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/readers/CSVDefaults.scala 0% <0%> (-100%) ⬇️
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd8aa2...b9fa09c. Read the comment docs.

Copy link
Collaborator

left a comment

LGTM

@tovbinm
tovbinm approved these changes Apr 2, 2019
@tovbinm tovbinm merged commit df42f37 into salesforce:master Apr 2, 2019
7 of 9 checks passed
7 of 9 checks passed
codecov/project 82.66% (-3.95%) compared to 7cd8aa2
Details
Travis CI - Pull Request Build Canceled
Details
CodeFactor No issues found.
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: compile-hw Your tests passed on CircleCI!
Details
ci/circleci: scala-style Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7cd8aa2...b9fa09c
Details
salesforce-cla All contributors have signed the CLA
Details
@tovbinm tovbinm referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.