Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub to allow loading models without workflow #269

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 8, 2019

Related issues
We are starting a sequence of PRs on allowing model loading without workflows...

Describe the proposed solution
Stub to allow loading models without workflow

Copy link
Contributor

@wsuchy wsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #269 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #269      +/-   ##
=========================================
- Coverage   86.41%   86.4%   -0.01%     
=========================================
  Files         318     318              
  Lines       10458   10461       +3     
  Branches      349     555     +206     
=========================================
+ Hits         9037    9039       +2     
- Misses       1421    1422       +1
Impacted Files Coverage Δ
.../op/stages/impl/feature/SubstringTransformer.scala 100% <ø> (ø) ⬆️
...main/scala/com/salesforce/op/OpWorkflowModel.scala 93.97% <100%> (+0.07%) ⬆️
.../src/main/scala/com/salesforce/op/OpWorkflow.scala 87.5% <100%> (ø) ⬆️
...cala/com/salesforce/op/OpWorkflowModelReader.scala 90.56% <100%> (+2.33%) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b652257...77a8afc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants