Add test for RealNNVectorizer #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovbinm
approved these changes
Apr 16, 2019
|
|
||
| val expectedResult: Seq[OPVector] = Array(-1.0, -4.0, 5.0, -5.5, 0.1, 2.0, 0.0).map(Array(_).toOPVector) | ||
|
|
||
| behavior of "RealNNVectorizerTest" |
There was a problem hiding this comment.
I don’t think god need to specify the ‘behavior’ as the test name is set in the base class
| import com.salesforce.op.test.{OpTransformerSpec, TestFeatureBuilder} | ||
|
|
||
|
|
||
| class RealNNVectorizerTest extends OpTransformerSpec[OPVector, RealNNVectorizer] { |
There was a problem hiding this comment.
Please add run with junit annotation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 86.4% 86.42% +0.01%
==========================================
Files 319 319
Lines 10453 10453
Branches 351 561 +210
==========================================
+ Hits 9032 9034 +2
+ Misses 1421 1419 -2
Continue to review full report at Codecov.
|
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Improve test coverage for transformers & estimators #278
Describe the proposed solution
Tests using
OpTransformerSpecand also checks.vectorizeshortcutDescribe alternatives you've considered
None
Additional context
None