Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements of Vectorizer tests #291

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Improvements of Vectorizer tests #291

merged 4 commits into from
Apr 17, 2019

Conversation

wsuchy
Copy link
Contributor

@wsuchy wsuchy commented Apr 17, 2019

Yet another tests changes

tovbinm
tovbinm approved these changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #291   +/-   ##
======================================
  Coverage    86.4%   86.4%           
======================================
  Files         319     319           
  Lines       10452   10452           
  Branches      346     346           
======================================
  Hits         9031    9031           
  Misses       1421    1421
Impacted Files Coverage Δ
...ce/op/stages/impl/feature/OpOneHotVectorizer.scala 96.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462226a...63c028c. Read the comment docs.

@wsuchy wsuchy merged commit f228f26 into master Apr 17, 2019
@tovbinm tovbinm deleted the ks/improved-tests-OPPivotVectorizerTest branch April 17, 2019 22:14
@Jauntbox Jauntbox mentioned this pull request May 2, 2019
Merged
@michaelweilsalesforce michaelweilsalesforce mentioned this pull request Jul 10, 2019
Closed
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@leahmcguire leahmcguire Awaiting requested review from leahmcguire leahmcguire is a code owner

Assignees
No one assigned
Labels
cla:missing ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsuchy @tovbinm