improved test SmartTextMapVectorizerTest #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 86.4% 86.42% +0.01%
==========================================
Files 322 322
Lines 10572 10572
Branches 349 566 +217
==========================================
+ Hits 9135 9137 +2
+ Misses 1437 1435 -2
Continue to review full report at Codecov.
|
tovbinm
reviewed
Apr 18, 2019
| * Estimator instance to be tested | ||
| */ | ||
| override val estimator: SmartTextMapVectorizer[TextMap] = new SmartTextMapVectorizer[TextMap]() | ||
| .setMaxCardinality(2).setNumFeatures(4).setMinSupport(1).setTopK(2).setPrependFeatureName(true) |
There was a problem hiding this comment.
let's perhaps test the stage with all the default settings, i.e. just val estimator: SmartTextMapVectorizer[TextMap] = new SmartTextMapVectorizer[TextMap]()
There was a problem hiding this comment.
@wsuchy can you please address my comment so we can merge this?
tovbinm
approved these changes
Apr 30, 2019
Merged
Closed
|
Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved test by extending OpEstimatorSpec trait