improved PercentileCalibratorTest #318
Conversation
| import spark.implicits._ | ||
|
|
||
| Spec[PercentileCalibrator] should "return a minimum calibrated score of 0 and max of 99 when buckets is 100" in { | ||
| val testData = Seq(10, 100, 1000).map(_.toRealNN) |
There was a problem hiding this comment.
why not use a bit of a larger sample?
There was a problem hiding this comment.
It is already being tested by 1000 elements sample later in that test, the major purpose of those values and extending of OpEstimatorSpec trait is for checking de/serializing into json, etc.
There was a problem hiding this comment.
Base spec is supposed to test everything including transformations, serialization etc. Further tests usually test for additional behavior which is not covered in the base test. It makes sense to test as much as you can in the base test and avoid additional ones.
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
+ Coverage 79.46% 86.51% +7.05%
==========================================
Files 325 325
Lines 10581 10581
Branches 349 565 +216
==========================================
+ Hits 8408 9154 +746
+ Misses 2173 1427 -746
Continue to review full report at Codecov.
|
|
Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement. |
No description provided.