Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descale feature contribution for Linear Regression & Logistic Regression #345

Merged
merged 43 commits into from
Jul 25, 2019
Merged

Descale feature contribution for Linear Regression & Logistic Regression #345

merged 43 commits into from
Jul 25, 2019

Commits on Jun 25, 2019

  1. move PR to a branch on Tmog

    @TuanNguyen27
    TuanNguyen27 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    fe8e6df View commit details
    Browse the repository at this point in the history

  2. add condition to descale only when it is Linear / Logistic regression… 

    … & the features are standardized during training
    @TuanNguyen27
    TuanNguyen27 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4ad6204 View commit details
    Browse the repository at this point in the history

  3. fix modelinsighttest

    @TuanNguyen27
    TuanNguyen27 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    1e2bc81 View commit details
    Browse the repository at this point in the history

  4. only compute descaled contrib if a model is present & fits our criteria

    @TuanNguyen27
    TuanNguyen27 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    5cbe132 View commit details
    Browse the repository at this point in the history

  5. fix test failure with a check for empty list of feature contribution

    @TuanNguyen27
    TuanNguyen27 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    673dad8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. addressing comments

    @TuanNguyen27
    TuanNguyen27 committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    4c44263 View commit details
    Browse the repository at this point in the history

  2. more comment addressing

    @TuanNguyen27
    TuanNguyen27 committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    d3fa01b View commit details
    Browse the repository at this point in the history

  3. test in progress, still broken

    @TuanNguyen27
    TuanNguyen27 committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    7a882f2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into tn/descaleLR

    @tovbinm
    tovbinm committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    8ba36c2 View commit details
    Browse the repository at this point in the history

  5. seems to be working

    @TuanNguyen27
    TuanNguyen27 committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    e4da5ab View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. first version of test

    @TuanNguyen27
    TuanNguyen27 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    0767e84 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tn/descaleLR' of https://github.com/salesforce/Transmog… 

    …rifAI into tn/descaleLR
    @TuanNguyen27
    TuanNguyen27 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    992db1a View commit details
    Browse the repository at this point in the history

  3. fix scala style

    @TuanNguyen27
    TuanNguyen27 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    7eaa209 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Merge branch 'master' into tn/descaleLR

    @tovbinm
    tovbinm committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    2c5d2f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    99236f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. addressing comments

    @TuanNguyen27
    TuanNguyen27 committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    e1bb482 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    00fb0d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    27a2449 View commit details
    Browse the repository at this point in the history

  2. change log to warn

    @TuanNguyen27
    TuanNguyen27 committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    cb798db View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Merge branch 'master' into tn/descaleLR

    @leahmcguire
    leahmcguire committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    3a541ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tn/descaleLR

    @leahmcguire
    leahmcguire committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    083448a View commit details
    Browse the repository at this point in the history

  3. fix an error in calculating standard deviation for discrete distribution

    @TuanNguyen27
    TuanNguyen27 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    606b6e1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'tn/descaleLR' of https://github.com/salesforce/Transmog… 

    …rifAI into tn/descaleLR
    @TuanNguyen27
    TuanNguyen27 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    1643635 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tn/descaleLR

    @leahmcguire
    leahmcguire committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    6ca53fc View commit details
    Browse the repository at this point in the history

  6. correctly pull out standard deviation for each feature

    @TuanNguyen27
    TuanNguyen27 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    4c432e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    4f252bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    4be8752 View commit details
    Browse the repository at this point in the history

  3. descale entire contribution vector & clearly separate out between lin… 

    …ear regression and logistic regression cases
    @TuanNguyen27
    TuanNguyen27 committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    0e63491 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'tn/descaleLR' of https://github.com/salesforce/Transmog… 

    …rifAI into tn/descaleLR
    @TuanNguyen27
    TuanNguyen27 committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    e6de82b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2019

  1. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    54d28a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. fix scala idiom

    @TuanNguyen27
    TuanNguyen27 committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    4677c96 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tn/descaleLR' of https://github.com/salesforce/Transmog… 

    …rifAI into tn/descaleLR
    @TuanNguyen27
    TuanNguyen27 committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    fa4221f View commit details
    Browse the repository at this point in the history

  3. remove logistic regression pattern matching

    @TuanNguyen27
    TuanNguyen27 committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    a5901d8 View commit details
    Browse the repository at this point in the history

  4. add citations for future readability

    @TuanNguyen27
    TuanNguyen27 committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    90ff504 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. refactor & add test for binary logistic regression case

    @TuanNguyen27
    TuanNguyen27 committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    a7dea4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tn/descaleLR

    @TuanNguyen27
    TuanNguyen27 committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    35bdfe8 View commit details
    Browse the repository at this point in the history

  3. remove redundant import

    @TuanNguyen27
    TuanNguyen27 committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    c6bae48 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. fix scala style

    @TuanNguyen27
    TuanNguyen27 committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    bc60187 View commit details
    Browse the repository at this point in the history

  2. fix scala style again

    @TuanNguyen27
    TuanNguyen27 committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    a6839b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Update warning message

    @TuanNguyen27
    TuanNguyen27 committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    23b2443 View commit details
    Browse the repository at this point in the history

  2. update failure threshold so test will pass

    @TuanNguyen27
    TuanNguyen27 committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    36c8420 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. update test to be ratio instead of absolute difference

    @TuanNguyen27
    TuanNguyen27 committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    c80cc1a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. small update to set tolerance threshold

    @TuanNguyen27
    TuanNguyen27 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    51627e9 View commit details
    Browse the repository at this point in the history