Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix the failing test #356

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Try to fix the failing test #356

merged 2 commits into from
Jul 9, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Jul 8, 2019

Related issues
Sometimes TravisCI fails to deserialize the model in test and fails with the following error:

com.salesforce.op.stages.base.sequence.SequenceEstimatorTest
  [+] SequenceEstimator[OPVector] should produce output feature (1 ms)
  [+] SequenceEstimator[OPVector] should copy (10 ms)
  [+] SequenceEstimator[OPVector] should be serializable (16 ms)
  [+] SequenceEstimator[OPVector] should fit a model (479 ms)
  [+] SequenceEstimator[OPVector] model should produce output feature (1 ms)
  [+] SequenceEstimator[OPVector] model should copy (20 ms)
  [+] SequenceEstimator[OPVector] model should be serializable (13 ms)
  [-] SequenceEstimator[OPVector] model should be json writable/readable (33 ms)
com.salesforce.op.stages.base.sequence.SequenceEstimatorTest > SequenceEstimator[OPVector] model should be json writable/readable FAILED
    org.scalatest.exceptions.TestFailedException: Failed to read the stage of type 'com.salesforce.op.stages.base.sequence.FractionOfResponsesModel'
        Caused by:
        java.lang.RuntimeException: Failed to read the stage of type 'com.salesforce.op.stages.base.sequence.FractionOfResponsesModel'
            Caused by:
            java.lang.RuntimeException: Failed to extract value for param 'counts' for an instance of type 'com.salesforce.op.stages.base.sequence.FractionOfResponsesModel' due to: Failed to parse argument 'counts' from value 'List(5, 4, 4)' of class 'scala.collection.immutable.$colon$colon'
                Caused by:
                java.lang.RuntimeException: Failed to parse argument 'counts' from value 'List(5, 4, 4)' of class 'scala.collection.immutable.$colon$colon'
                    Caused by:
                    org.json4s.package$MappingException: Parsed JSON values do not match with class constructor
                    args=
                    arg types=
                    constructor=public scala.Int()

Describe the proposed solution
Trying out different solutions...

Describe alternatives you've considered
NA

@tovbinm tovbinm requested a review from leahmcguire as a code owner July 8, 2019 23:04
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #356 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   86.72%   86.73%   +0.01%     
==========================================
  Files         336      336              
  Lines       10799    10799              
  Branches      346      346              
==========================================
+ Hits         9365     9367       +2     
+ Misses       1434     1432       -2
Impacted Files Coverage Δ
...es/src/main/scala/com/salesforce/op/OpParams.scala 89.79% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25f4eb...fc67bd1. Read the comment docs.

@tovbinm tovbinm merged commit 3b82d96 into master Jul 9, 2019
@tovbinm tovbinm deleted the mt/list branch July 9, 2019 16:38
This was referenced Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant