-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detecting names in text fields #440
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Spark dataframes
… a guess as to the gender of the name
…d log results to console if names were detected
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 86.93% 83.17% -3.77%
==========================================
Files 337 339 +2
Lines 11096 11296 +200
Branches 362 597 +235
==========================================
- Hits 9646 9395 -251
- Misses 1450 1901 +451
Continue to review full report at Codecov.
|
… to be more informative; Fixed detection counting null values when it should ignore them
Closing to rework on comments from reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartTextVectorizer
now has an optional flagdetectSensitive
that will guess, using a combination of dictionary lookup and conditional logic, whether any of the input columns are names (which we don't want in our models in case of bias). For right now, just a warning is logged to console that there may be such names in the input fields. In the future, theremoveSensitive
flag will remove those columns from contributing to the output vector. Also in the future, the gender information that is extracted from name columns (using government data) will be used to check for model fairness.A unary estimator
HumanNameIdentifier
is also included as a standalone drop-in for custom workflows.Additional context
I completed this work as part of my ongoing Salesforce internship. This PR cleans up and replaces #428.