Incorporate name detection into SmartTextVectorizer #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onoids instead of custom accumulators
… Still need to fix HLL serialization in Spark issue
…ix printing bug for NameDetectStats
…stead of moments of text length; Still need to fix no moments higher than the 1st being calculated
…Cleaned up test code
MWYang
requested review from
gerashegalov,
Jauntbox,
leahmcguire,
tovbinm and
wsuchy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
===========================================
- Coverage 87% 74.72% -12.28%
===========================================
Files 341 341
Lines 11485 11532 +47
Branches 378 597 +219
===========================================
- Hits 9992 8617 -1375
- Misses 1493 2915 +1422
Continue to review full report at Codecov.
|
Jauntbox
reviewed
Jan 29, 2020
| dataset.map(_.map(computeTextStats(_, shouldCleanText)).toArray).reduce(_ + _), | ||
| Array.fill[NameDetectStats](inN.length)(NameDetectStats.empty) | ||
| ) | ||
| } else { |
There was a problem hiding this comment.
Can you make the formatting of both if branches look the same since they're doing nearly the same thing?
Jauntbox
reviewed
Jan 29, 2020
| // In which case create SensitiveFeatureInformation for all features | ||
| case ((feature: String, key: Option[String]), stats: NameDetectStats) | ||
| if log.isDebugEnabled || computeTreatAsName(stats) => | ||
| val N = stats.dictCheckResult.count.toDouble |
There was a problem hiding this comment.
more descriptive name, please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the proposed solution
Incorporates the changes in #445 and #457 into
SmartTextVectorizerandSmartTextMapVectorizer.Additional context
Merge #457 before merging this PR. Compare the diff between this PR and that one on my forked repo.
Changes from #455 needs to be merged before this PR is ready.