Adding unit test for FeatureHistory #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gokulsfdc
commented
Aug 20, 2018
gokulsfdc
commented
- Added unit tests for FeatureHistory class
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 86.11% 86.34% +0.23%
==========================================
Files 298 298
Lines 9305 9762 +457
Branches 303 531 +228
==========================================
+ Hits 8013 8429 +416
- Misses 1292 1333 +41
Continue to review full report at Codecov.
|
tovbinm
approved these changes
Aug 20, 2018
| val stage1 = "stage1" | ||
| val stage2 = "stage2" | ||
|
|
||
| Spec(FeatureHistory.getClass) should "convert a feature history to metadata" in { |
There was a problem hiding this comment.
Since there is an actual class you can do: Spec[FeatureHistory] instead
| } | ||
|
|
||
| it should "merge two featurehistory" in { | ||
| val featureHistory1 = FeatureHistory(originFeatures = Seq(feature1), stages = Seq(stage1)) |
There was a problem hiding this comment.
No need to repeat featurehistory in the test name. Simply "merge two instances"
There was a problem hiding this comment.
Same in other tests @gokulsfdc
| val featureHistory1 = FeatureHistory(originFeatures = Seq(feature1), stages = Seq(stage1)) | ||
| val featureHistory2 = FeatureHistory(originFeatures = Seq(feature2), stages = Seq(stage2)) | ||
|
|
||
| val map = Map[String, FeatureHistory](("1" -> featureHistory1), ("2" -> featureHistory2)) |
There was a problem hiding this comment.
No need to specify map type.
|
Please remove “featurehistory” from test names. |
gokulsfdc
force-pushed
the
unitest_featurehistory
branch
from
5c5cebb
to
9417a10
Compare
ericwayman
pushed a commit
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.