Stable key order for map vectorizers #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys being naturally sorted now
leahmcguire
approved these changes
Aug 24, 2018
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 85.97% 85.98% +0.01%
==========================================
Files 294 294
Lines 9547 9548 +1
Branches 352 336 -16
==========================================
+ Hits 8208 8210 +2
+ Misses 1339 1338 -1
Continue to review full report at Codecov.
|
| @@ -124,14 +123,14 @@ class IntegralMapVectorizer[T <: OPMap[Long]](uid: String = UID[IntegralMapVecto | |||
| def setFillWithMode(shouldFill: Boolean): this.type = set(withConstant, !shouldFill) | |||
|
|
|||
| override def fillByKey(dataset: Dataset[Seq[T#Value]]): Seq[Map[String, Double]] = { | |||
There was a problem hiding this comment.
nit: it looks like fillByKey in RealMapVectorizer and IntegralMapVectorizer have a very small diff. Maybe refactor.
ericwayman
pushed a commit
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Map vectorizers do not order the keys properly.
Describe the proposed solution
MapVectorizerFuns.getKeyValuesfunction.Describe alternatives you've considered
N/A