Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove guava as a dependency of bazel-java-sdk #219

Closed
plaird opened this issue May 11, 2021 · 1 comment
Closed

Remove guava as a dependency of bazel-java-sdk #219

plaird opened this issue May 11, 2021 · 1 comment
Assignees
@plaird
Labels
tech debt

Comments

@plaird
Copy link
Contributor

plaird commented May 11, 2021

I am working on a new project (non-IDE related) that needs the bazel-java-sdk. I just copied it out of BEF into that other repo for now. We have #188 to move the bazel-java-sdk to a new Git repo so it is standalone and more easily shared.

But another thing we need to do is strip Guava from it. It uses it for just two reasons: ImmutableList and Precondition. Those aren't enough to add a big dep like Guava. I removed Guava in that other repo's copy, but we need to do it here too.
@plaird plaird self-assigned this May 11, 2021
@plaird
Copy link
Contributor Author

plaird commented May 14, 2021

Removed in #222

@plaird plaird closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plaird plaird

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plaird