This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorYasko121
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Apr 15, 2020
IgorYasko121
force-pushed
the
59-negative-project-import-tests
branch
from
April 15, 2020 11:09
998b2cd
to
1da8b44
Compare
IgorYasko121
force-pushed
the
59-negative-project-import-tests
branch
from
April 16, 2020 07:53
1da8b44
to
524771b
Compare
kkazakevich
requested review from
PMitrafanau,
LeonovecSergey and
beginningineer
April 16, 2020 18:03
kkazakevich
approved these changes
Apr 16, 2020
beginningineer
suggested changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks great except a couple of comments.
com.salesforce.b2eclipse.tests/projects/build-with-subpackage/module1/BUILD
Outdated
Show resolved
Hide resolved
...ests/src/main/java/com/salesforce/b2eclipse/importer/BuildWithSubPackageBazelImportTest.java
Outdated
Show resolved
Hide resolved
IgorYasko121
force-pushed
the
59-negative-project-import-tests
branch
from
April 21, 2020 05:58
9de5bcd
to
c743746
Compare
beginningineer
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank a lot!
@SuppressWarnings("restriction") | ||
public class BazelImportTest { | ||
public abstract class BaseBazelImproterTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo BaseBazelImpROterTest
...e.b2eclipse.jdt.ls/src/main/java/com/salesforce/b2eclipse/managers/B2EPreferncesManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Proposed Changes
Additional Info