Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: any number of project configs is processed #114

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

a-hoff
Copy link
Contributor

@a-hoff a-hoff commented Jul 17, 2018

Details

Config was not correctly processing config files that had a single entry in their project properties. This fixes it so that it will correctly process any number of project entries.

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9243159 | Target commit: b57b542

simple-benchmark-prod

object_keys metric base(9243159) target(b57b542) trend
stringify_parse duration 35.10 (± 0.30 ms) 36.00 (± 0.20 ms) -2.56% 👎
deep_merge duration 26.30 (± 0.95 ms) 27.10 (± 1.00 ms) -3.04% 👌

simple-benchmark-compat

object_keys metric base(9243159) target(b57b542) trend
stringify_parse duration 34.70 (± 0.40 ms) 34.15 (± 0.25 ms) 1.59% 👍
deep_merge duration 114.20 (± 2.30 ms) 112.15 (± 1.75 ms) 1.80% 👍

lwc-examples-prod

simple-item metric base(9243159) target(b57b542) trend
create_and_render duration 51.10 (± 0.70 ms) 50.70 (± 0.50 ms) 0.78% 👌

lwc-examples-compat

simple-item metric base(9243159) target(b57b542) trend
create_and_render duration 84.90 (± 1.10 ms) 84.25 (± 0.95 ms) 0.77% 👍

@@ -362,7 +362,7 @@ export async function getConfigs(projectsFromCLIArgs, argv) {
}
}

if (projects.length > 1) {
if (projects.length > 0) {
Copy link
Contributor

@diervo diervo Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there was a reason for this number, but maybe this is ok.
Could you double check that a project with a default unique config runs just fine?
Otherwise I will try to check later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this works for both

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge the pending PRs today or tomorrow.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 6294d67 | Target commit: 8b21501

simple-benchmark-prod

object_keys metric base(6294d67) target(8b21501) trend
stringify_parse duration 36.55 (± 0.65 ms) 34.60 (± 0.10 ms) 5.34% 👍
deep_merge duration 27.90 (± 1.90 ms) 25.10 (± 0.15 ms) 10.04% 👍

simple-benchmark-compat

object_keys metric base(6294d67) target(8b21501) trend
stringify_parse duration 35.35 (± 0.60 ms) 34.40 (± 0.30 ms) 2.69% 👍
deep_merge duration 112.35 (± 3.95 ms) 112.40 (± 1.30 ms) -0.04% 👌

lwc-examples-prod

simple-item metric base(6294d67) target(8b21501) trend
create_and_render duration 53.40 (± 1.40 ms) 53.80 (± 2.10 ms) -0.75% 👌

lwc-examples-compat

simple-item metric base(6294d67) target(8b21501) trend
create_and_render duration 89.40 (± 2.20 ms) 87.10 (± 1.60 ms) 2.57% 👍

@diervo diervo merged commit c72dced into salesforce:master Aug 17, 2018
@diervo diervo deleted the ahoff-fix-project-config-parsing branch August 17, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants