Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade pupeteer and fix trend #122

Merged
merged 2 commits into from
Sep 4, 2018
Merged

fix: Upgrade pupeteer and fix trend #122

merged 2 commits into from
Sep 4, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 4, 2018

Details

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: d283352 | Target commit: c52cb2b

simple-benchmark-prod

object_keys metric base(d283352) target(c52cb2b) trend
stringify_parse duration 37.45 (±0.75 ms) 39.20 (±2.30 ms) +1.8ms (4.7%) 👎
deep_merge duration 28.55 (±2.10 ms) 31.90 (±2.70 ms) +3.3ms (11.7%) 👎

simple-benchmark-compat

object_keys metric base(d283352) target(c52cb2b) trend
stringify_parse duration 34.60 (±0.70 ms) 41.00 (±4.80 ms) +6.4ms (18.5%) 👎
deep_merge duration 113.95 (±3.50 ms) 125.60 (±11.00 ms) +11.7ms (10.2%) 👎

lwc-examples-prod

simple-item metric base(d283352) target(c52cb2b) trend
create_and_render duration 53.30 (±1.10 ms) 60.20 (±5.40 ms) +6.9ms (12.9%) 👎

lwc-examples-compat

simple-item metric base(d283352) target(c52cb2b) trend
create_and_render duration 88.30 (±1.60 ms) 101.35 (±6.95 ms) +13.0ms (14.8%) 👎

@diervo diervo merged commit d041743 into master Sep 4, 2018
@diervo diervo deleted the dval/upgrade branch September 4, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant