Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ability to measure benchmark deltas across commits/branches #133

Open
nolanlawson opened this issue Jan 25, 2019 · 1 comment

Comments

@nolanlawson
Copy link
Contributor

Use case: Locker Service would like to measure the performance of the browser eval() vs Locker secureEval(). We can write Best benchmarks to independently measure each, but there's no way AFAICT to measure the delta between the two, across commits.

So for instance, if eval() itself regresses between Chrome 71 and Chrome 72, we don't care. But if the delta between our secureEval() and eval() regresses, then we actually care. We can track the two independently and infer this, but it would be better if Best had something built-in to handle this use case.

Other use cases that may want this scenario: measuring LWC vs Aura, polyfill vs native, etc.

@diervo
Copy link
Contributor

diervo commented Feb 1, 2019

Not sure I understand this use case. Let's talk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants