Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Documentation! #175

Merged
merged 65 commits into from
Sep 3, 2019
Merged

feat: Documentation! #175

merged 65 commits into from
Sep 3, 2019

Conversation

jasonsilberman
Copy link
Contributor

@jasonsilberman jasonsilberman commented Jul 18, 2019

This contains the documentation for using Best!

@jasonsilberman jasonsilberman changed the base branch from v4 to master July 19, 2019 18:02
Copy link
Member

@pmdartus pmdartus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to be able to review the PR and follow the new installation steps, however, I wasn't able to find the package released beta version of the package on either http://registry.npmjs.com or https://npm.lwcjs.org. Where is the beta version of the package published?

@jasonsilberman
Copy link
Contributor Author

@pmdartus, great question! Diego was having some major troubles with npm. We will try to publish soon

cc/ @diervo

docs/src/client/home.html Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
docs/content/docs/getting-started.md Show resolved Hide resolved
docs/content/docs/running-remotely.md Outdated Show resolved Hide resolved
docs/content/docs/running-remotely.md Outdated Show resolved Hide resolved
docs/content/docs/continuous-integration.md Outdated Show resolved Hide resolved
docs/content/docs/frontend.md Outdated Show resolved Hide resolved
docs/content/docs/frontend.md Outdated Show resolved Hide resolved
docs/content/docs/getting-started.md Outdated Show resolved Hide resolved
docs/content/docs/running-remotely.md Outdated Show resolved Hide resolved
@salesforce-best-lwc-internal
Copy link

🥳 Performance Improvement

Best has detected that there is a 25.5% performance improvement across your benchmarks.

Please click here to see more details.

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 15.1% performance regression across your benchmarks.

Please click here to see more details.

@salesforce-best-lwc-internal
Copy link

🥳 Performance Improvement

Best has detected that there is a 7.4% performance improvement across your benchmarks.

Please click here to see more details.

docs/src/client/home.html Outdated Show resolved Hide resolved
@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 21.8% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

best-benchmark

❌ Regressions base (bcb43be) target (d6b3b3f) trend
js-execution/fibonacci 38 603.48 (± 21.00ms) 937.45 (± 15.61ms) +334.0ms (55.3%)
js-execution3/fibonacci 567.27 (± 3.03ms) 934.00 (± 27.57ms) +366.7ms (64.6%)

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 7.5% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

best-benchmark

❌ Regressions base (12a29f2) target (83f5d97) trend
js-execution/fibonacci 38 540.34 (± 0.22ms) 612.28 (± 22.32ms) +71.9ms (13.3%)
js-execution3/fibonacci 540.43 (± 0.25ms) 630.98 (± 36.23ms) +90.5ms (16.8%)

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 18.4% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

best-benchmark

❌ Regressions base (b371e6d) target (53f913b) trend
js-execution/fibonacci 38 647.81 (± 2.46ms) 869.47 (± 46.26ms) +221.7ms (34.2%)
js-execution3/fibonacci 648.86 (± 1.93ms) 903.70 (± 86.19ms) +254.8ms (39.3%)

@jasonsilberman
Copy link
Contributor Author

@diervo any movement on this?

@diervo diervo merged commit e4f9f72 into master Sep 3, 2019
@diervo diervo deleted the jsilberman/docs branch September 3, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants