Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improving GitHub Checks #182

Merged
merged 13 commits into from
Jul 31, 2019
Merged

feat: Improving GitHub Checks #182

merged 13 commits into from
Jul 31, 2019

Conversation

jasonsilberman
Copy link
Contributor

@jasonsilberman jasonsilberman commented Jul 26, 2019

Details

This is a work in progress to improve the GitHub integration with checks and comments.

  • Add summary of significant improvements and regressions
  • Move comparison table to text section of check
  • Ignore metric percentage change (to check for comment threshold) if the value is less than 1ms.

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 11.0% performance regression across your benchmarks.

Please click here to see more details.

@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 5.7% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

best-benchmark

❌ Regressions base (aaf6473) target (21c8091) trend
js-execution/fibonacci 38 584.55 (± 9.85ms) 647.74 (± 30.04ms) +63.2ms (10.8%)
js-execution3/fibonacci 586.47 (± 18.77ms) 707.35 (± 49.77ms) +120.9ms (20.6%)

packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
packages/@best/github-integration/src/analyze.ts Outdated Show resolved Hide resolved
@jasonsilberman
Copy link
Contributor Author

@apapko i tried to abstract the similar functions into some generators if you want to take another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants