Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bug Fixes, Easier Hub Authentication, Filter Out Metrics #195

Merged
merged 10 commits into from
Aug 5, 2019

Conversation

jasonsilberman
Copy link
Contributor

Details

  • Fixes issue where the estimated time was incorrect and even negative when a single iteration was slow.
  • Fix issue with the path not being properly truncated in the runner stream
  • Removes the JWT authentication in favor of a simple secret matching scheme
  • Introduces metrics into config so you can choose which metrics you want to be measured in your benchmarks

@jasonsilberman jasonsilberman changed the title feat: Bug Fixes, Easier Hub Authentication, Choose Which Metrics You Want feat: Bug Fixes, Easier Hub Authentication, Filter Out Metrics Aug 5, 2019
@salesforce-best-lwc-internal
Copy link

⚠ Performance Regression

Best has detected that there is a 7.5% performance regression across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

best-benchmark

❌ Regressions base (bcb43be) target (cf83af1) trend
js-execution3/fibonacci 567.27 (± 3.03ms) 738.26 (± 11.79ms) +171.0ms (30.1%)

Copy link
Contributor

@diervo diervo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, but look good

@jasonsilberman jasonsilberman merged commit 44825a4 into master Aug 5, 2019
@jasonsilberman jasonsilberman deleted the jsilberman/cleaning branch August 5, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants