Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollup multiple chunks issues #213

Merged
merged 1 commit into from
Oct 28, 2019
Merged

fix: rollup multiple chunks issues #213

merged 1 commit into from
Oct 28, 2019

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Oct 28, 2019

Details

The new version of rollup might generate multiple chunks if the bundle is too big. For Best we want to avoid this since one bundle is what we want.

jodarove
jodarove approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@jodarove jodarove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diervo diervo merged commit 8344162 into master Oct 28, 2019
@diervo diervo deleted the dval/avoidChunks branch October 28, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodarove jodarove jodarove approved these changes

@jasonsilberman jasonsilberman Awaiting requested review from jasonsilberman

@nolanlawson nolanlawson Awaiting requested review from nolanlawson

@pmdartus pmdartus Awaiting requested review from pmdartus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diervo @jodarove