feat: add frontend api for snapshots upload #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajric
requested review from
jodarove,
nolanlawson and
pmdartus
as code owners
alrra
requested review from
jodarove,
nolanlawson and
pmdartus
and removed request for
nolanlawson,
jodarove and
pmdartus
alrra
reviewed
Dec 3, 2021
dbajric
commented
Dec 3, 2021
| import jwt from 'jsonwebtoken'; | ||
|
|
||
| const TOKEN_SECRET = process.env.TOKEN_SECRET as string; | ||
| const REVOKED_TOKENS = (process.env.REVOKED_TOKENS || "").split("\n"); |
There was a problem hiding this comment.
This could also be read from a file. Maybe that would be better. Thoughts?
Co-authored-by: Cătălin Mariș <cmaris@salesforce.com>
alrra
reviewed
Dec 6, 2021
alrra
approved these changes
Dec 6, 2021
alrra
pushed a commit
that referenced
this pull request
Dec 6, 2021
sf-v
pushed a commit
that referenced
this pull request
Apr 7, 2022
sf-v
pushed a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Results can now be stored in the database through an REST API exposed by the frontend instead of directly connecting to the database. This provides a more secure model by allowing BEST deployments to not have to expose the database to the public.
In addition to the new provider and the new API in frontend, I have also added a simple JSON Web Token-based authorization with a revocation list support. Currently, only the new API used to publish results is using this auth filter.
Does this PR introduce a breaking change?