Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): Adding default commit size to 7 characters #50

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jan 19, 2018

PR Checklist

What kind of change does this PR introduce? (add 'x' - [x])

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

The PR fulfills these requirements:

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 93124b8 | Target commit: 08fadee

benchmark base(93124b8) target(08fadee) trend
simple-item-clone.benchmark:create_and_render 79.09 (± 2.22 ms) 79.84 (± 2.22 ms) 👌
simple-item.benchmark:create_and_render 76.92 (± 2.21 ms) 79.25 (± 2.21 ms) 👎

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 93124b8 | Target commit: f7ec1fd

benchmark base(93124b8) target(f7ec1fd) trend
simple-item-clone.benchmark:create_and_render 79.09 (± 1.27 ms) 77.33 (± 1.27 ms) 👍
simple-item.benchmark:create_and_render 76.92 (± 1.71 ms) 77.38 (± 1.71 ms) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 93124b8 | Target commit: 17c97d9

benchmark base(93124b8) target(17c97d9) trend
simple-item-clone.benchmark:create_and_render 79.09 (± 1.14 ms) 73.35 (± 1.14 ms) 👍
simple-item.benchmark:create_and_render 76.92 (± 0.62 ms) 74.39 (± 0.62 ms) 👍

@diervo
Copy link
Contributor Author

diervo commented Jan 19, 2018

@pmdartus this fixed the issue in raptor (for some reason git was using 8char hash rather than the regular default 7)

@diervo diervo merged commit e3261c0 into master Jan 19, 2018
@diervo diervo deleted the dval/fixCommitDefaultSize branch January 19, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant