Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(best-compare): Fix comparer recursivity #65

Merged
merged 3 commits into from
Feb 4, 2018
Merged

feat(best-compare): Fix comparer recursivity #65

merged 3 commits into from
Feb 4, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 3, 2018

No description provided.

@diervo diervo changed the title style(prettier): Prettify new files feat(best-compare): Fix comparer recursivity Feb 3, 2018
@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 04e946c | Target commit: a3c253a

benchmark base(04e946c) target(a3c253a) trend
object_keys.benchmark:stringify_parse 0.67 (± 0.01 ms) 0.28 (± 0.01 ms) 👍
simple-item.benchmark:create_and_render 124.36 (± 0.48 ms) 59.55 (± 0.48 ms) 👍

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 04e946c | Target commit: bdfecbc

benchmark base(04e946c) target(bdfecbc) trend
object_keys.benchmark:stringify_parse 0.67 (± 0.03 ms) 0.60 (± 0.03 ms) 👍
object_keys.benchmark:deep_merge 0.73 (± 0.03 ms) 0.67 (± 0.03 ms) 👍
simple-item.benchmark:create_and_render 124.36 (± 4.91 ms) 96.22 (± 4.91 ms) 👍

@diervo diervo merged commit bf6efec into master Feb 4, 2018
@diervo diervo deleted the dval/pretty branch February 4, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant