Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(best-frontend): Fix defaults. Adding minor guards #81

Merged
merged 2 commits into from
Feb 11, 2018
Merged

fix(best-frontend): Fix defaults. Adding minor guards #81

merged 2 commits into from
Feb 11, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 11, 2018

Details

  • Rename github package
  • Fix minor guard for runDuration
  • Change default storage name

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 1fb2089 | Target commit: aa0c014

benchmark base(1fb2089) target(aa0c014) trend
object_keys.benchmark:stringify_parse 34.31 (± 0.05 ms) 37.09 (± 0.68 ms) 👎
object_keys.benchmark:deep_merge 24.54 (± 0.32 ms) 27.37 (± 2.16 ms) 👎
simple-item.benchmark:create_and_render 50.90 (± 0.55 ms) 56.63 (± 1.71 ms) 👎

@diervo diervo merged commit 5992eaf into master Feb 11, 2018
@diervo diervo deleted the dval/minorUpdates branch February 11, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diervo