Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(best-build): Allow custom plugins #84

Merged
merged 3 commits into from
Feb 16, 2018
Merged

fix(best-build): Allow custom plugins #84

merged 3 commits into from
Feb 16, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 16, 2018

Details

  • Allow custom plugins to be defined
  • Change plugins format
  • Fix minor bug on mesager interactive output.

Does this PR introduce a breaking change?

  • Yes
  • No

Plugins config options API has changed:

Before

{
... 
plugins: {...}
}

After

{
... 
plugins: [
 'p1',
[['p2', { optionsP2 }]
]
}

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 21cc9b5 | Target commit: 4cf1c39

benchmark base(21cc9b5) target(4cf1c39) trend
object_keys.benchmark:stringify_parse 36.64 (± 0.63 ms) 35.89 (± 0.10 ms) 👍
object_keys.benchmark:deep_merge 28.90 (± 2.12 ms) 24.27 (± 0.14 ms) 👍
simple-item.benchmark:create_and_render 56.65 (± 1.37 ms) 51.57 (± 0.56 ms) 👍

@diervo diervo merged commit 8f77b1e into master Feb 16, 2018
@diervo diervo deleted the dval/customPlugins branch February 16, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant