Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Git integration, FE plot index #93

Merged
merged 2 commits into from
Mar 15, 2018
Merged

fix: Git integration, FE plot index #93

merged 2 commits into from
Mar 15, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 15, 2018

Details

  • Adds multiple tables for output comparison
  • Fixes plot index on frontend package

Does this PR introduce a breaking change?

  • No

If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:

Reminders ( please delete this section before submitting )


The PR fulfills these requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Title

LWC PR title follows conventional commit format and is automatically validated by our CI.

ex:
commit-type(optional scope): commit description. ( NOTE: space between column and the message )

Types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test, proposal.
Scope: The scope should be the name of the npm package affected (engine, compiler, wire-service, etc.)

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 1f86ba0 | Target commit: fd9d67b

object_keys (simple-benchmarks) base(1f86ba0) target(fd9d67b) trend
stringify_parse 36.70 (± 0.50 ms) 34.70 (± 0.25 ms) 5.45% 👍
deep_merge 26.80 (± 1.10 ms) 25.90 (± 0.80 ms) 3.36% 👍
simple-item (lwc-examples-prod) base(1f86ba0) target(fd9d67b) trend
create_and_render 51.50 (± 0.70 ms) 50.90 (± 0.50 ms) 1.17% 👍
simple-item (lwc-examples-compat) base(1f86ba0) target(fd9d67b) trend
create_and_render 86.90 (± 1.15 ms) 104.40 (± 11.15 ms) -20.14% 👎

@diervo diervo merged commit 9dad1fb into master Mar 15, 2018
@diervo diervo deleted the dval/fixTables branch March 15, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant