Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow local (fs) comparison #96

Merged
merged 17 commits into from
Mar 19, 2018
Merged

feat: Allow local (fs) comparison #96

merged 17 commits into from
Mar 19, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 19, 2018

Details

Allow offline (file-system) comparison between two arbitrary commits.

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: e1bdbb7 | Target commit: 78310db

object_keys (simple-benchmarks) base(e1bdbb7) target(78310db) trend
stringify_parse 34.30 (± 0.10 ms) 35.30 (± 0.30 ms) -2.92% 👎
deep_merge 25.15 (± 0.85 ms) 25.85 (± 0.75 ms) -2.78% 👎
simple-item (lwc-examples-prod) base(e1bdbb7) target(78310db) trend
create_and_render 50.00 (± 0.40 ms) 51.90 (± 0.40 ms) -3.80% 👎
simple-item (lwc-examples-compat) base(e1bdbb7) target(78310db) trend
create_and_render 83.70 (± 0.70 ms) 85.90 (± 0.90 ms) -2.63% 👎

@diervo diervo merged commit 5781d55 into master Mar 19, 2018
@diervo diervo deleted the dval/compare branch March 19, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant