Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Credentials Exposure as a finding #99

Closed
kmcquade opened this issue Sep 17, 2020 · 1 comment · Fixed by #124
Closed

Add Credentials Exposure as a finding #99

kmcquade opened this issue Sep 17, 2020 · 1 comment · Fixed by #124
Assignees
@kmcquade
Labels
ui User interface stuff

Comments

@kmcquade
Copy link
Collaborator

kmcquade commented Sep 17, 2020 •
edited

This gist shows actions that return credentials. https://gist.github.com/kmcquade/33860a617e651104d243c324ddf7992a

We should have this show up as more of an informational finding in the report. It's important to track, but depending on the result, it isn't necessarily bad (example: ecr:GetAuthorizationToken)
@kmcquade kmcquade self-assigned this Sep 17, 2020
kmcquade added a commit to kmcquade/cloudsplaining that referenced this issue Sep 17, 2020
@kmcquade
Added findings for Credentials Exposure (salesforce#99) and Service W…
f98e5ad 
…ildcard (salesforce#82) to the scan-policy-file command. Improved direct function calls to scan_policy_file.scan_policy
@kmcquade kmcquade mentioned this issue Sep 17, 2020
Merged
4 tasks
kmcquade added a commit that referenced this issue Sep 17, 2020
@kmcquade
Added findings for Credentials Exposure and Service Wildcard to scan-…
cf040e2 
…policy-file command (#100)

* Added findings for Credentials Exposure (#99) and Service Wildcard (#82) to the scan-policy-file command. Improved direct function calls to scan_policy_file.scan_policy

* Reduce size of pull request template
@kmcquade kmcquade added the ui User interface stuff label Oct 1, 2020
@kmcquade
Copy link
Collaborator Author

kmcquade commented Oct 1, 2020

Labeled with UI, since I added this to the JSON data output already

kmcquade added a commit to kmcquade/cloudsplaining that referenced this issue Oct 12, 2020
@kmcquade
Fixes salesforce#99 by adding support for Credentials Exposure and Fixes
6b03658 
 salesforce#82 by adding support for Service Wildcard.
@kmcquade kmcquade mentioned this issue Oct 12, 2020
Merged
5 tasks
kmcquade added a commit that referenced this issue Oct 12, 2020
@kmcquade
Adds Credentials Exposure and Service Wildcard to the report (#124)
fe84e38 
* Updated risk alert indicator and definitions

* Fixed formatting in StandardRiskDetails v-bind IDs; updated order of risk details to display; made finding details only show up if they exist via v-if

* Added the Credentials Exposure and Service Wildcard findings to the finding details per policy

* Added alert indicators for the new risks

* The new findings are present in the table now

* Fixes #99 by adding support for Credentials Exposure and Fixes #82 by adding support for Service Wildcard.

* Update javascript bundle and generate a new example report
verkaufer pushed a commit to verkaufer/cloudsplaining that referenced this issue Dec 10, 2020
@kmcquade @verkaufer
Added findings for Credentials Exposure and Service Wildcard to scan-…
0419b7a 
…policy-file command (salesforce#100)

* Added findings for Credentials Exposure (salesforce#99) and Service Wildcard (salesforce#82) to the scan-policy-file command. Improved direct function calls to scan_policy_file.scan_policy

* Reduce size of pull request template
verkaufer pushed a commit to verkaufer/cloudsplaining that referenced this issue Dec 10, 2020
@kmcquade @verkaufer
Adds Credentials Exposure and Service Wildcard to the report (salesfo…
eba7575 
…rce#124)

* Updated risk alert indicator and definitions

* Fixed formatting in StandardRiskDetails v-bind IDs; updated order of risk details to display; made finding details only show up if they exist via v-if

* Added the Credentials Exposure and Service Wildcard findings to the finding details per policy

* Added alert indicators for the new risks

* The new findings are present in the table now

* Fixes salesforce#99 by adding support for Credentials Exposure and Fixes salesforce#82 by adding support for Service Wildcard.

* Update javascript bundle and generate a new example report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcquade kmcquade

Labels
ui User interface stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds Credentials Exposure and Service Wildcard to the report kmcquade/cloudsplaining
1 participant
@kmcquade